chore: bump rust-dashcore rev to 95a3c8ff04d75d7abe324db4af01e8521092aff9 by ZocoLini · Pull Request #3955 · dashpay/platform

ZocoLini · 2026-06-23T11:26:15Z

With this rust-dashcore bump we introduce a fix for some swift sdk panics under specific conditions

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

I have assigned this pull request to a milestone

Summary by CodeRabbit

Release Notes

Chores
- Updated dashcore ecosystem package dependencies to their latest revisions, including dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, and dashcore-rpc.

coderabbitai · 2026-06-23T11:26:24Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 63e94dbb-7684-425f-8d0d-c526d44663d6

📥 Commits

Reviewing files that changed from the base of the PR and between 87f6b73 and bc9c65b.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

Cargo.toml

📝 Walkthrough

Walkthrough

Updates the git rev pins for eight dashcore-ecosystem crates (dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dashcore-rpc) in [workspace.dependencies] of Cargo.toml to a new revision hash.

Changes

DashCore Revision Bump

Layer / File(s)	Summary
Workspace dependency rev pins `Cargo.toml`	Updates the git `rev` hash for all eight dashcore-ecosystem crates in `[workspace.dependencies]`; no other dependency values are changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

dashpay/platform#3729: Updates the same [workspace.dependencies] git rev pins for the same set of dashcore-ecosystem crates in Cargo.toml.
dashpay/platform#3757: Identical change pattern — bumps dashcore ecosystem git rev hashes in Cargo.toml workspace dependencies.
dashpay/platform#3762: Directly overlaps at the dependency-pin level, bumping the same dashcore-family git rev hashes in Cargo.toml.

Suggested reviewers

QuantumExplorer

Poem

🐇 Hop, hop, a new hash in sight,
Eight crates all pinned to the right commit tonight.
dashcore and friends get a fresh little tag,
No logic to change, just a new git brag.
The bunny approves — it's a clean little snip! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: bumping the rust-dashcore revision to a specific commit hash, which is the core purpose of this dependency maintenance PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/bump-rust-dashcore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

thepastaclaw · 2026-06-23T11:27:05Z

✅ Review complete (commit bc9c65b)

thepastaclaw

Code Review

Convergent blocking finding from both agents: Cargo.lock was not regenerated after bumping the rust-dashcore git rev in Cargo.toml. CI uses --locked, so the manifest/lockfile mismatch will break builds and prevent consumers from actually receiving the upstream Swift-SDK panic fix this PR advertises.

🔴 1 blocking

1 additional finding(s) omitted (not in diff).

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `Cargo.lock`:
- [BLOCKING] Cargo.lock:1640: Cargo.lock not regenerated for new rust-dashcore rev
  Cargo.toml lines 53–60 pin all 8 rust-dashcore workspace deps (dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dashcore-rpc) to rev 95a3c8ff04d75d7abe324db4af01e8521092aff9, but Cargo.lock still records each of those crates from the prior rev 5c0113e7901551450f6063023eec4be95beeb6b9 (verified at lines 1640, 1651, 1728, 1757, 1783, …). The project's Rust CI invokes Cargo with --locked, so the manifest/lockfile inconsistency will fail the build immediately. More importantly, until the lockfile is regenerated, the stated fix for swift-sdk panics is not actually delivered to anyone building via --locked or to the iOS xcframework build pipeline that consumes key-wallet-ffi / dash-spv through rs-unified-sdk-ffi. Regenerate the lockfile (e.g. `cargo update -p dashcore -p dash-network-seeds -p dash-spv -p key-wallet -p key-wallet-ffi -p key-wallet-manager -p dash-network -p dashcore-rpc`) and commit the resulting Cargo.lock changes alongside the Cargo.toml bump.

…aff9

thepastaclaw

Code Review

The prior Cargo.lock mismatch is FIXED: Cargo.toml and all rust-dashcore-sourced Cargo.lock entries now point to rev 95a3c8ff04d75d7abe324db4af01e8521092aff9, and the old 5c0113e7901551450f6063023eec4be95beeb6b9 rev is no longer present in the checked manifests or lockfile. cargo metadata --locked --no-deps --format-version 1 succeeds, confirming the lockfile is internally consistent with the current workspace manifests. No agent or CodeRabbit findings remain to carry forward.

ZocoLini requested a review from QuantumExplorer as a code owner June 23, 2026 11:26

ZocoLini marked this pull request as draft June 23, 2026 12:05

ZocoLini marked this pull request as ready for review June 23, 2026 12:10

thepastaclaw suggested changes Jun 23, 2026

View reviewed changes

chore: bump rust-dashcore rev to 95a3c8ff04d75d7abe324db4af01e8521092…

bc9c65b

…aff9

ZocoLini force-pushed the chore/bump-rust-dashcore branch from 277f6f1 to bc9c65b Compare June 23, 2026 13:43

thepastaclaw approved these changes Jun 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump rust-dashcore rev to 95a3c8ff04d75d7abe324db4af01e8521092aff9#3955

chore: bump rust-dashcore rev to 95a3c8ff04d75d7abe324db4af01e8521092aff9#3955
ZocoLini wants to merge 1 commit into
v3.1-devfrom
chore/bump-rust-dashcore

ZocoLini commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

thepastaclaw commented Jun 23, 2026 •

edited

Loading

Uh oh!

thepastaclaw left a comment

Uh oh!

thepastaclaw left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ZocoLini commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist:

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

thepastaclaw commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thepastaclaw left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

thepastaclaw left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ZocoLini commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

thepastaclaw commented Jun 23, 2026 •

edited

Loading